Fix masterbar showing and install broken in Desktop Mode windows#33
Merged
Conversation
- Pass desktop_mode_chromeless=1 to both iframe URLs so the WordPress masterbar is suppressed inside native windows - Use window.top instead of window.parent for install postMessage calls so blueprints reach Playground even when my-apps is nested inside a Desktop Mode iframe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?desktop_mode_chromeless=1to both iframe URLs so the WordPress masterbar is suppressed inside native windowswindow.parent.postMessagefor install messages withgetPlaygroundTarget().postMessage, which walks up the parent chain until it hits a cross-origin frame (Playground) — so installs work whether my-apps is loaded directly inside Playground or nested inside a Desktop Mode iframeTest plan