Skip to content

improve encoding/decoding #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
al8n merged 22 commits into from
Mar 3, 2025
Merged

improve encoding/decoding #73

al8n merged 22 commits into from
Mar 3, 2025

Conversation

@al8n
Copy link
Owner

@al8n al8n commented Feb 25, 2025

No description provided.

@codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.48649% with 186 lines in your changes missing coverage. Please review.

Project coverage is 69.59%. Comparing base (c74643a) to head (128174b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
memberlist-proto/src/address.rs 63.29% 29 Missing ⚠️
memberlist-proto/src/push_pull/state.rs 53.96% 29 Missing ⚠️
memberlist-proto/src/data/tuple.rs 64.78% 25 Missing ⚠️
memberlist-proto/src/lib.rs 52.63% 18 Missing ⚠️
memberlist-proto/src/alive.rs 56.41% 17 Missing ⚠️
memberlist-proto/src/ack.rs 61.90% 16 Missing ⚠️
memberlist-proto/src/encryption.rs 79.03% 13 Missing ⚠️
memberlist-proto/src/push_pull.rs 75.55% 11 Missing ⚠️
...erlist-proto/src/proto/decoder/repeated_decoder.rs 74.35% 10 Missing ⚠️
memberlist-proto/src/err.rs 44.44% 5 Missing ⚠️
... and 5 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   68.74%   69.59%   +0.85%     
==========================================
  Files          72       75       +3     
  Lines        6923     7190     +267     
==========================================
+ Hits         4759     5004     +245     
- Misses       2164     2186      +22
Files with missing lines Coverage Δ
memberlist-core/src/base.rs 72.47% <100.00%> (ø)
memberlist-core/src/lib.rs 50.00% <ø> (ø)
memberlist-core/src/network.rs 53.55% <ø> (ø)
memberlist-core/src/network/packet/handler.rs 79.48% <100.00%> (ø)
memberlist-core/src/network/stream.rs 73.62% <100.00%> (-0.57%) ⬇️
memberlist-core/src/suspicion.rs 79.01% <ø> (ø)
memberlist-core/src/transport.rs 100.00% <100.00%> (+75.00%) ⬆️
memberlist-core/src/transport/stream.rs 33.75% <ø> (ø)
memberlist-net/src/promised_processor.rs 72.50% <ø> (-2.50%) ⬇️
memberlist-proto/src/data/nodecraft.rs 86.66% <ø> (ø)
... and 22 more

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c74643a...128174b. Read the comment docs.

@al8n al8n merged commit ed17c11 into main Mar 3, 2025
29 of 30 checks passed
@al8n al8n deleted the optimization branch March 3, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@al8n