Distribute hold-tier execution rewards from the incentives pool#10
Open
moshemalawach wants to merge 1 commit into
Open
Distribute hold-tier execution rewards from the incentives pool#10moshemalawach wants to merge 1 commit into
moshemalawach wants to merge 1 commit into
Conversation
Upstream aleph-api-credit PR #5 adds an optional `rewards` array to `aleph_credit_expense` execution messages for holder-tier instances — the user paid by holding ALEPH, not by burning credits, so node operators are paid from the incentives pool instead of user revenue. Route `rewards` entries through the same 60/15/20/5 split as `credits` (CRN / CCN / stakers / dev fund), tracked separately as `hold_rewards_total_aleph` in the published distribution post for auditing. Gated by `credit_hold_rewards_enabled` (default true) mirroring the upstream `@temporary` flag. Rename the inner accumulator from `rewards` to `payouts` to free the name for the new message field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream aleph-api-credit PR #5 (
feat/hold-execution-rewards) adds an optionalrewardsarray toaleph_credit_expenseexecution messages for holder-tier instances — the user paid by holding ALEPH, not by burning credits. Node operators should still be paid for running these workloads, but from the incentives pool rather than from user revenue.rewardsentries alongside existingcreditsinaleph_credit_expenseexecution messages.hold_rewards_total_alephin the publishedcredit-rewards-distributionpost so accounting can distinguish user-paid from incentives-pool-paid payouts.credit_hold_rewards_enabled(defaulttrue), mirroring the upstream@temporaryJOB_EXPENSE_HOLD_ENABLEDflag.rewardstopayoutsto free the name for the new message field.Test plan
nodestatus-distributeon testnet against messages that containrewardsand verify the summary shows the split correctly.rewardsfield) produce identical numbers to the previous behavior.credit_hold_rewards_enabled=falseand verifyhold_rewards_total_alephis 0 and the field is still present in the post.pytest).