Skip to content

Fix & Improve aggregates + Add permission commands#330

Merged
nesitor merged 2 commits into
masterfrom
feat-fix-and-improve-aggregates
Feb 11, 2025
Merged

Fix & Improve aggregates + Add permission commands#330
nesitor merged 2 commits into
masterfrom
feat-fix-and-improve-aggregates

Conversation

@philogicae
Copy link
Copy Markdown
Member

@philogicae philogicae commented Jan 29, 2025 •
edited
Loading

Jira: ALEPH-402

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Documentation

Changes

  • Fix existing commands: forget, post, get
  • Add command: list
  • Add commands to manage permissions: authorize, revoke, permissions
  • General improvement and UX upgrade
  • Add all tests (none until now)

How to test

Try out all commands

image

Screenshots

aleph aggregate post | get | forget

With key only

image

With key and subkey(s)

image

aleph aggregate list

image

aleph aggregate authorize | revoke | permissions

image

@philogicae philogicae marked this pull request as ready for review January 30, 2025 11:46
@philogicae philogicae force-pushed the feat-fix-and-improve-aggregates branch from c75f6e0 to e1870a5 Compare January 30, 2025 11:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.87958% with 90 lines in your changes missing coverage. Please review.

Project coverage is 57.42%. Comparing base (0e35d70) to head (7386c60).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/aggregate.py 51.87% 57 Missing and 33 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   57.17%   57.42%   +0.24%     
==========================================
  Files          18       18              
  Lines        2592     2762     +170     
  Branches      330      377      +47     
==========================================
+ Hits         1482     1586     +104     
- Misses        937      970      +33     
- Partials      173      206      +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 30, 2025

Failed to retrieve llama text: POST 500: 500: Unhandled error during initialisation

@philogicae philogicae force-pushed the feat-fix-and-improve-aggregates branch from e1870a5 to 7386c60 Compare January 30, 2025 12:10
@nesitor nesitor merged commit ba35b91 into master Feb 11, 2025
@nesitor nesitor deleted the feat-fix-and-improve-aggregates branch February 11, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nesitor nesitor nesitor approved these changes

@olethanh olethanh Awaiting requested review from olethanh

@1yam 1yam Awaiting requested review from 1yam

Assignees

@philogicae philogicae

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@philogicae @nesitor