fix(ci): rename release binaries to avoid asset name collisions#123
Merged
Conversation
The #label in `gh release upload "file#label"` only sets the display name — the actual asset filename is the uploaded file's name. All non-Windows matrix jobs produced a binary called `aleph`, so --clobber made them overwrite each other (only one survived). Fix by copying the binary to the unique asset_name before uploading, and revert the separate upload-release-assets job from 398e048 since it is no longer needed.
foxpatch-aleph
approved these changes
Mar 23, 2026
foxpatch-aleph
left a comment
There was a problem hiding this comment.
This PR correctly fixes the asset name collision issue by renaming binaries to unique names before upload. The solution is cleaner and more efficient than the previous approach with separate artifact upload/download jobs. The added permissions are necessary, and dependency updates are correct. No bugs or security issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #label in
gh release upload "file#label"only sets the display name — the actual asset filename is the uploaded file's name. All non-Windows matrix jobs produced a binary calledaleph, so --clobber made them overwrite each other (only one survived).Fix by copying the binary to the unique asset_name before uploading, and revert the separate upload-release-assets job from 398e048 since it is no longer needed.