Cleanup: Code cleanup#240
Merged
Merged
Conversation
odesenfans
approved these changes
Oct 5, 2022
Contributor
odesenfans
left a comment
There was a problem hiding this comment.
Two minor comments, looks good otherwise. I'm surprised the missing typing imports were not caught sooner.
Cleanup multiple warnings without affecting the behaviour.
odesenfans
approved these changes
Oct 5, 2022
aliel
pushed a commit
that referenced
this pull request
Feb 18, 2026
Clean-up multiple warnings without affecting the behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup multiple warnings without affecting the behaviour.