Skip to content

Revive examples page by fixing configuration issues#169

Merged
alewin merged 1 commit into
alewin:masterfrom
wanaryytel:revive-examples
Mar 9, 2025
Merged

Revive examples page by fixing configuration issues#169
alewin merged 1 commit into
alewin:masterfrom
wanaryytel:revive-examples

Conversation

@wanaryytel

@wanaryytel wanaryytel commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

This PR

  • fixes configuration issues that prevented examples from working before
    • @koale/useworker not linked correctly (still has to be built manually though)
    • wrong vite root directory in examples
    • calling tsc in examples workspace that doesn't use typescript
  • adds missing dependencies to examples
  • migrates from using react-toast-notifications to react-hot-toast because react-toast-notifications doesn't support react 18
  • fixes bubble sort typo :)

@pkg-pr-new

pkg-pr-new Bot commented Mar 7, 2025

Copy link
Copy Markdown

Open in Stackblitz

npm i https://pkg.pr.new/alewin/useWorker/@koale/useworker@169

commit: d657027

@alewin

alewin commented Mar 9, 2025

Copy link
Copy Markdown
Owner

Excellent work! @wanaryytel 👏 thanks you

@alewin alewin merged commit 09ac8af into alewin:master Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants