Mark worker as not running immediately after being killed#171
Merged
alewin merged 1 commit intoMar 9, 2025
Merged
Conversation
This change is necessary so that the client could kill a worker and then immediately start a new worker. Without this change `useWorker()` will error out and say that you can only run one instance at a time because the running status is not updated until the next render cycle. If we mark it as not running immediately then the client can immediately create a new worker without having to wait for that to happen.
commit: |
Owner
|
good catch @wanaryytel thanks |
alewin
approved these changes
Mar 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is necessary so that the client could kill a worker and then immediately start a new worker. Without this change
useWorker()will error out and say that you can only run one instance at a time because the running status is not updated until the next render cycle. If we mark it as not running immediately then the client can immediately create a new worker without having to wait for that to happen.