Skip to content

[Pick][0.7 to 0.8] | Fix double free in socket pool on unexpected photon thread switch (#1029) #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lihuiba merged 1 commit into from
Nov 3, 2025
Merged

[Pick][0.7 to 0.8] | Fix double free in socket pool on unexpected photon thread switch (#1029) #1030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion net/pooled_socket.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ class TCPSocketPool : public ForwardSocketClient {
list.erase(node);
if (list.empty()) fdmap.erase(it);
rm_watch(node);
delete node;
}

public:
Expand Down Expand Up @@ -250,6 +249,7 @@ class TCPSocketPool : public ForwardSocketClient {
// socket shutdown
drop_from_pool(nodes[i]);
}
for (int i = 0; i < ret; i++) delete nodes[i];
}
}
};
Expand Down
Loading