Skip to content

feat: add function return for event setter #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liujuping merged 1 commit into from
Dec 30, 2022
Merged

feat: add function return for event setter #1424

liujuping merged 1 commit into from
Dec 30, 2022

Conversation

@AndyJinSS
Copy link
Contributor

@AndyJinSS AndyJinSS commented Dec 30, 2022

为事件设置器绑定的函数模板增加return，解决物料内部需要根据使用侧绑定的函数来控制内部状态的需求，例如弹窗中确认按钮根据onOk函数是否结束并返回bool值控制按钮的loading以及是否关闭弹窗（类似ModalForm）

@liujuping
Copy link
Collaborator

liujuping commented Dec 30, 2022

具体是什么样的表现？可以提供一个 demo / 更详细的描述说明这个改动导致的影响吗？

@AndyJinSS
Copy link
Contributor Author

AndyJinSS commented Dec 30, 2022

具体是什么样的表现？可以提供一个 demo / 更详细的描述说明这个改动导致的影响吗？

image
关联到这个issue
#1420

这个pr主要变动是之前的event setter生成的代码如下
"onOk": { "type": "JSFunction", "value": "function(){ this.onOk.apply(this,Array.prototype.slice.call(arguments).concat([])) }" }
改完之后事件绑定生成代码会如下（增加了return）
"onOk": { "type": "JSFunction", "value": "function(){return this.onOk.apply(this,Array.prototype.slice.call(arguments).concat([])) }" }

@liujuping liujuping merged commit c6d65db into alibaba:develop Dec 30, 2022
@AndyJinSS AndyJinSS mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liujuping liujuping Awaiting requested review from liujuping liujuping is a code owner

@JackLian JackLian Awaiting requested review from JackLian JackLian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyJinSS @liujuping