Skip to content

Conversation

@liujuping
Copy link
Collaborator

No description provided.

@liujuping liujuping requested a review from JackLian as a code owner May 11, 2023 02:02
@github-actions
Copy link

github-actions bot commented May 11, 2023

ChatGPT Code Review:

代码的功能是在 lowcode-editor-skeleton 中,在 ISkeleton 接口中增加了一个 add 方法,用于在 Skeleton 中增加一个新的 widget 或 panel,具体实现由内部模块 skeleton 实现,并返回添加的 IPublicModelSkeletonItem 实例。另外,在设计器中,增加了一个 IDocumentModel 接口,其中将 open 方法的返回类型改为了 IDocumentModel。同时,对 IProp 接口进行了修改,增加了 spread 和 isVirtual 方法。在 engine 模块中,增加了 SkeletonItem 类,在它上面增加了 types 和 symbols 的导出和引用。在 shell 模块中,对 Skeleton 类的 add 方法增加了返回类型的限制,返回类型必须是 IPublicModelSkeletonItem 的实例或 undefined,同时增加了对 getAreaItems 方法的实现。对 symbols 进行了更新,增加了 SkeletonItem 的 symbol。在 types 模块中,增加了 IPublicModelSkeletonItem 接口。在 view-context 中增加了 editorWindow 和 viewName 字段。

@github-actions
Copy link

github-actions bot commented May 11, 2023

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.18% 119/247
🔴 Branches 42.64% 113/265
🔴 Functions 41.03% 32/78
🔴 Lines 49.36% 115/233

Test suite run success

32 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from d7a923e

@github-actions
Copy link

github-actions bot commented May 11, 2023

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from d7a923e

@github-actions
Copy link

github-actions bot commented May 11, 2023

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 71.95% 908/1262
🟡 Branches 61.23% 567/926
🟡 Functions 69.12% 197/285
🟡 Lines 71.94% 892/1240

Test suite run success

91 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from d7a923e

@github-actions
Copy link

github-actions bot commented May 11, 2023

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.41% 2843/2949
🟢 Branches
89.06% (+0.01% 🔼)
1628/1828
🟢 Functions 95.97% 858/894
🟢 Lines 96.48% 2770/2871

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from d7a923e

@liujuping liujuping force-pushed the feat/skeleton-item branch from 727db1e to d7a923e Compare May 11, 2023 02:13
@JackLian JackLian merged commit 239bb29 into develop May 11, 2023
@JackLian JackLian deleted the feat/skeleton-item branch May 11, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants