Skip to content

Conversation

@haoyann
Copy link
Collaborator

@haoyann haoyann commented Jul 22, 2021

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

The snakeyaml processor is not thread-safe.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Jul 22, 2021
@KomachiSion KomachiSion merged commit 2624002 into alibaba:develop Jul 22, 2021
@KomachiSion KomachiSion added this to the 2.0.3 milestone Jul 22, 2021
@haoyann haoyann deleted the yaml-threads branch September 9, 2021 07:15
zrlw added a commit to zrlw/nacos that referenced this pull request Jan 10, 2022
zrlw added a commit to zrlw/nacos that referenced this pull request Feb 21, 2022
CherishCai pushed a commit to CherishCai/nacos that referenced this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants