Skip to content

Upgrade jackson version to 2.12.6.1 #8383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
li-xiao-shuang merged 1 commit into from
May 18, 2022
Merged

Upgrade jackson version to 2.12.6.1 #8383

li-xiao-shuang merged 1 commit into from
May 18, 2022

Conversation

@KomachiSion
Copy link
Collaborator

@KomachiSion KomachiSion commented May 16, 2022

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the dependencies Pull requests that update a dependency file label May 16, 2022
@KomachiSion KomachiSion added this to the 2.1.1 milestone May 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #8383 (83eb30e) into develop (b928568) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8383      +/-   ##
=============================================
+ Coverage      41.23%   41.31%   +0.08%     
- Complexity      4374     4377       +3     
=============================================
  Files            873      873              
  Lines          31813    31813              
  Branches        3705     3705              
=============================================
+ Hits           13119    13145      +26     
+ Misses         17385    17359      -26     
  Partials        1309     1309
Impacted Files Coverage Δ
...ent/manager/impl/EphemeralIpPortClientManager.java 66.00% <0.00%> (-2.00%) ⬇️
...a/nacos/core/remote/control/TpsMonitorManager.java 54.54% <0.00%> (-1.30%) ⬇️
.../naming/push/v1/NamingSubscriberServiceV1Impl.java 66.66% <0.00%> (ø)
.../core/v2/event/publisher/NamingEventPublisher.java 76.25% <0.00%> (ø)
...naming/core/v2/metadata/NamingMetadataManager.java 79.74% <0.00%> (+1.26%) ⬆️
...a/com/alibaba/nacos/naming/push/v1/PushClient.java 46.93% <0.00%> (+2.04%) ⬆️
...de/doublewrite/delay/DoubleWriteEventListener.java 66.66% <0.00%> (+3.70%) ⬆️
...alibaba/nacos/client/config/impl/ClientWorker.java 55.29% <0.00%> (+4.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b928568...83eb30e. Read the comment docs.

@li-xiao-shuang li-xiao-shuang merged commit 3901534 into alibaba:develop May 18, 2022
@KomachiSion KomachiSion deleted the develop-upgrade-jackson branch May 20, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@li-xiao-shuang li-xiao-shuang li-xiao-shuang approved these changes

@hujun-w-2 hujun-w-2 hujun-w-2 approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

2.1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@KomachiSion @codecov-commenter @li-xiao-shuang @hujun-w-2