nacos ui doc update to v2 #10730
Merged
nacos ui doc update to v2 #10730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KomachiSion
previously approved these changes
Jul 5, 2023
Collaborator
|
Sorry, there is some one change console code so that conflicts. Can you solve it . |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10730 +/- ##
=============================================
- Coverage 53.66% 53.52% -0.15%
- Complexity 5520 5523 +3
=============================================
Files 897 897
Lines 28885 28885
Branches 3181 3181
=============================================
- Hits 15502 15460 -42
- Misses 12029 12065 +36
- Partials 1354 1360 +6 see 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
|
Seems the v2 documents still need to get more improvement |
# Conflicts: # console/src/main/resources/static/index.html # console/src/main/resources/static/js/main.js
Contributor
Author
|
I think there will be no conflict. |
KomachiSion
approved these changes
Jul 10, 2023
lowezheng
added a commit
to lowezheng/nacos
that referenced
this pull request
Jul 11, 2023
* develop: Refactor grpc tls (alibaba#10759) dump change check task submit (alibaba#10755) [ISSUE alibaba#10734] Implement http request param check filter and http param extractors (alibaba#10758) nacos ui doc update to v2 (alibaba#10730) fix for react unique key warning (alibaba#10742) [ISSUE alibaba#10734] Implement grpc server interceptor and grpc param extractors (alibaba#10745) improvements for leave node api and UI (alibaba#10748) Delete client version (alibaba#10754)
wukong121
pushed a commit
to wukong121/nacos
that referenced
this pull request
Aug 4, 2023
* nacos ui doc update to v2 * nacos ui doc update to v2 * fix conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
update nacos doc link, fix #10729
Brief changelog
change links in js files
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.