Skip to content

Conversation

@shiyiyue1102
Copy link
Collaborator

1.optimize config dump all,do not select content in page query,single query config on md5 and ts updated.
2. remove convertDeleteConfig and convertConfigConfig ,use standard RowMapper instead.

… query config on md5 and ts updated.

2. remove convertDeleteConfig and convertConfigConfig ,use standard RowMapper instead.
@shiyiyue1102
Copy link
Collaborator Author

#11632

@codecov-commenter
Copy link

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (f3fb60e) 65.84% compared to head (8cb3161) 66.68%.
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11658      +/-   ##
=============================================
+ Coverage      65.84%   66.68%   +0.84%     
- Complexity      8692     8838     +146     
=============================================
  Files           1237     1237              
  Lines          40607    40657      +50     
  Branches        4321     4329       +8     
=============================================
+ Hits           26739    27114     +375     
+ Misses         11941    11576     -365     
- Partials        1927     1967      +40     
Files Coverage Δ
...acos/config/server/service/ConfigCacheService.java 73.62% <100.00%> (ø)
...ig/server/service/dump/DumpChangeConfigWorker.java 89.04% <100.00%> (ø)
.../nacos/config/server/service/dump/DumpService.java 80.76% <100.00%> (ø)
...r/service/repository/ConfigInfoPersistService.java 100.00% <ø> (ø)
...embedded/EmbeddedConfigInfoPersistServiceImpl.java 82.00% <100.00%> (ø)
...d/EmbeddedHistoryConfigInfoPersistServiceImpl.java 95.71% <100.00%> (-0.80%) ⬇️
.../extrnal/ExternalConfigInfoPersistServiceImpl.java 76.40% <100.00%> (ø)
...l/ExternalHistoryConfigInfoPersistServiceImpl.java 98.93% <100.00%> (-0.18%) ⬇️
...libaba/nacos/config/server/utils/PropertyUtil.java 45.07% <100.00%> (+11.17%) ⬆️
...datasource/impl/derby/ConfigInfoMapperByDerby.java 69.62% <100.00%> (-0.45%) ⬇️
... and 6 more

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3fb60e...8cb3161. Read the comment docs.

@KomachiSion KomachiSion linked an issue Jan 19, 2024 that may be closed by this pull request
@KomachiSion KomachiSion added this to the 2.3.1 milestone Jan 19, 2024
@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Jan 19, 2024
@KomachiSion KomachiSion merged commit 849393c into alibaba:develop Jan 19, 2024
@shiyiyue1102 shiyiyue1102 deleted the develop-optimize-dump branch January 19, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/Config kind/enhancement Category issues or prs related to enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nacos 2.3.0 DumpChangeConfigWorker NPE

3 participants