Skip to content

[ISSUE #12773] Fix unfriendly message when adding duplicate permissions or binding relationship. #12926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KomachiSion merged 6 commits into from
Dec 6, 2024
Merged

[ISSUE #12773] Fix unfriendly message when adding duplicate permissions or binding relationship. #12926

KomachiSion merged 6 commits into from
Dec 6, 2024

Conversation

@DirtyBit64
Copy link
Contributor

@DirtyBit64 DirtyBit64 commented Dec 5, 2024

What is the purpose of the change

Resolve the same issues in role management and permission management in the console : #12773.

Brief changelog

Modified com.alibaba.nacos.plugin.auth.impl.roles.NacosRoleServiceImpl.addXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@github-actions
Copy link

github-actions bot commented Dec 5, 2024

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io

感谢您提交的PR。 🙏
请再次查看您的PR内容，确认是否包含任何使用方式/API/配置参数的变更，如：新增API、新增配置参数、修改默认配置等操作。
如果是，请确保在提交之前，在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档（markdown格式）。

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.23%. Comparing base (6029ea4) to head (6da6dbb).

Files with missing lines Patch % Lines
...s/plugin/auth/impl/roles/NacosRoleServiceImpl.java 25.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12926      +/-   ##
=============================================
- Coverage      72.25%   72.23%   -0.02%     
  Complexity      9915     9915              
=============================================
  Files           1301     1301              
  Lines          41728    41736       +8     
  Branches        4393     4396       +3     
=============================================
  Hits           30149    30149              
- Misses          9468     9473       +5     
- Partials        2111     2114       +3
Files with missing lines Coverage Δ
...s/plugin/auth/impl/roles/NacosRoleServiceImpl.java 27.56% <25.00%> (-0.14%) ⬇️

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6029ea4...6da6dbb. Read the comment docs.

@DirtyBit64 DirtyBit64 mentioned this pull request Dec 5, 2024
Merged
@KomachiSion KomachiSion merged commit d4f5421 into alibaba:develop Dec 6, 2024
7 checks passed
@KomachiSion KomachiSion added this to the 2.5.0 milestone Dec 6, 2024
@KomachiSion KomachiSion added the area/Nacos console Related to Nacos consle label Dec 6, 2024
@DirtyBit64 DirtyBit64 deleted the develop_console branch December 6, 2024 08:52
@wuyfee
Copy link

wuyfee commented Dec 6, 2024

$\color{red}{FAILURE}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
❌ - e2e-nodejs-test (standalone & cluster): failure
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees

No one assigned

Labels

area/Nacos console Related to Nacos consle

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@DirtyBit64 @codecov-commenter @wuyfee @KomachiSion