feat: 修复jest单元测试，并新增当全部翻译插件失效时，取中文首字母拼音作为translate #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
|
#377 关联Issue |
z979054461
reviewed
Jun 21, 2023
z979054461
reviewed
Jun 21, 2023
| getFullChars: function (str) { | ||
| let result = '', | ||
| name; | ||
| // let reg = new RegExp('[a-zA-Z0-9- ]'); |
z979054461
reviewed
Jun 21, 2023
| for (let key in this.full_dict) { | ||
| if (-1 !== this.full_dict[key].indexOf(str)) { | ||
| return this._capitalize(key); | ||
| break; |
Contributor
Author
|
@z979054461 已去除无用注释，谢谢 |
Collaborator
|
你单独提一下pinyin好了，单元测试我来修 |
Contributor
Author
|
@z979054461 已去除单元测试的修复，仅上次pinyin代码，谢谢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce(这个 PR 引入了什么样的变化)?
Does this PR introduce a breaking change(这次 PR 引入了一个重大变化吗)?
If yes, please describe the impact and migration path for existing applications(如果是，请描述现有应用程序的影响和迁移路径):
The PR fulfills these requirements(PR 符合以下要求)
Other information(其他信息)
修复了单元测试引用路径问题，个人觉得依赖外部插件作为翻译有风险，应当在最后的选项提供一个默认的（比如取中文首字母）的方案作为不报错的备用方案，否则在使用Vs-code插件的时候，排查错误比较困难。