fix: 枚举包含数值时，生成的类型声明重复 #391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
z979054461
reviewed
Jan 22, 2024
Collaborator
|
关于这个问题，我觉得改这一句就好了，你看一下？ |
lc-soft
commented
Feb 5, 2024
| let enums = enumStrs as Array<string | number>; | ||
|
|
||
| enumStrs.forEach((str) => { | ||
| if (!Number.isNaN(Number(str))) { |
Author
There was a problem hiding this comment.
关于这个问题，我觉得改这一句就好了，你看一下？ !Number.isNaN(Number(str)) => !Number.isNumber(str) && !Number.isNaN(Number(str))
@z979054461 Number.isNumber 不存在，用 typeof 代替？
!Number.isNumber(str) -> typeof str === 'string' ？
Collaborator
There was a problem hiding this comment.
不好意思说错了 本来想说lodash的（_.isNumber），看了下他的实现处理了Number的包装对象，这里讲道理应该不会出现包装对象。
这里可以用typeof str !== 'number' 也可以 !_.isNumber(str)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce(这个 PR 引入了什么样的变化)?
Does this PR introduce a breaking change(这次 PR 引入了一个重大变化吗)?
If yes, please describe the impact and migration path for existing applications(如果是，请描述现有应用程序的影响和迁移路径):
The PR fulfills these requirements(PR 符合以下要求)
Other information(其他信息)