Skip to content

Fix incompatibility with recent cx_Freeze#1480

Merged
fabiencastan merged 1 commit into
alicevision:developfrom
DataBeaver:cx_freeze_compatibility
Jul 22, 2021
Merged

Fix incompatibility with recent cx_Freeze#1480
fabiencastan merged 1 commit into
alicevision:developfrom
DataBeaver:cx_freeze_compatibility

Conversation

@DataBeaver

Copy link
Copy Markdown
Contributor

In cx_Freeze 6.7, released last week, the startup code was changed so the run() function in the startup module is given the name of the main module as an argument. This causes meshroom to fail to start on Linux (and presumably also on macOS, which uses the same startup script) with a confusing error:

Traceback (most recent call last):
  File ".../cx_Freeze/initscripts/__startup__.py", line 104, in run
    module_init.run(name + "__main__")
TypeError: run() takes 0 positional arguments but 1 was given

This change makes meshroom compatible with new cx_Freeze, while retaining the old behaviour if run() received no arguments.

The run() function of the startup script now gets the main module name
as a parameter.
@fabiencastan fabiencastan added this to the Meshroom 2021.2.0 milestone Jul 22, 2021
@fabiencastan fabiencastan merged commit 7fdd102 into alicevision:develop Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants