Fix incompatibility with recent cx_Freeze#1480
Merged
fabiencastan merged 1 commit intoJul 22, 2021
Merged
Conversation
The run() function of the startup script now gets the main module name as a parameter.
fabiencastan
approved these changes
Jul 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cx_Freeze 6.7, released last week, the startup code was changed so the run() function in the startup module is given the name of the main module as an argument. This causes meshroom to fail to start on Linux (and presumably also on macOS, which uses the same startup script) with a confusing error:
This change makes meshroom compatible with new cx_Freeze, while retaining the old behaviour if run() received no arguments.