Skip to content

Fix compatibility with Python 3#1734

Merged
fabiencastan merged 1 commit into
developfrom
fix/python3-compatibility
Jul 21, 2022
Merged

Fix compatibility with Python 3#1734
fabiencastan merged 1 commit into
developfrom
fix/python3-compatibility

Conversation

@cbentejac

Copy link
Copy Markdown
Contributor

Description

This PR fixes a couple of deprecation warnings with Python 3:

  • import "collections" correctly depending on the used version of Python (fixes DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working)
  • use a raw string for a regex compilation (fixes DeprecationWarning: invalid escape sequence \{)

- Import "collections" correctly depending on the version of
Python
- Fix regex that raised deprecation warnings in Python 3
@cbentejac cbentejac requested a review from fabiencastan July 19, 2022 13:14
@fabiencastan fabiencastan added this to the Meshroom 2022.1.0 milestone Jul 21, 2022
@fabiencastan fabiencastan merged commit 18d0835 into develop Jul 21, 2022
@fabiencastan fabiencastan deleted the fix/python3-compatibility branch July 21, 2022 10:26
@cbentejac cbentejac linked an issue Mar 18, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import error with python 3.10

3 participants