[ui] Display nodes computed in another Meshroom instance as "Computed Externally"#1862
Merged
Conversation
A node running externally used to mean it was running on a submitter. This definition has been extended and a node is now considered to be external if it is running on a submitter or running in another instance of Meshroom. The "Computed Externally" is updated to reflect that change.
…ernal Prior to this commit, a node was considered external if its first chunk's execution mode was EXTERN. In some cases, a node can be submitted externally but have its first chunk's execution mode as LOCAL. This can occur if computations are started locally then stopped and resumed externally. If any chunk completed its computations locally, then its execution mode will remain LOCAL, even if the node is submitted externally later on. A node is now considered external if at least one of its chunks' execution mode is external.
sbrood
reviewed
Jan 10, 2023
sbrood
left a comment
Contributor
There was a problem hiding this comment.
Tested only for the case with 2 meshroom instances, it works. 👍
fabiencastan
approved these changes
Jan 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a bugfix and a minor UI improvement:
A node is now considered as computed externally if at least one of its chunks' execution mode is external.
Features list