Skip to content

[ui] add new patterns to load images in viewer2D#1975

Merged
fabiencastan merged 1 commit into
developfrom
dev/viewer2DFilePathPatterns
Apr 18, 2023
Merged

[ui] add new patterns to load images in viewer2D#1975
fabiencastan merged 1 commit into
developfrom
dev/viewer2DFilePathPatterns

Conversation

@sbrood

@sbrood sbrood commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

Description

This PR adds the support of new patterns to load images in the 2D image viewer. It will also be easier to add ones.

Features list

  • Add < FILENAME > and < INSTRINSIC_ID > pattern
  • patterns are given through a dictionary

@sbrood sbrood requested review from cbentejac and mugulmd April 12, 2023 16:21
@fabiencastan fabiencastan added this to the Meshroom 2023.2.0 milestone Apr 12, 2023
Comment thread meshroom/ui/components/filepath.py Outdated
Comment thread meshroom/ui/qml/Viewer/Viewer2D.qml Outdated
Comment thread meshroom/ui/qml/Viewer/Viewer2D.qml Outdated
Comment thread meshroom/ui/qml/Viewer/Viewer2D.qml
Comment thread meshroom/ui/qml/Viewer/Viewer2D.qml
@sbrood sbrood requested review from fabiencastan and mugulmd April 18, 2023 07:36
@mugulmd

mugulmd commented Apr 18, 2023

Copy link
Copy Markdown
Contributor

Your 2nd commit is labeled TO SQUASH, can you squash it so the git history is clean ? Thanks 😄

@sbrood sbrood force-pushed the dev/viewer2DFilePathPatterns branch from 6072542 to 731440e Compare April 18, 2023 12:46
@fabiencastan fabiencastan merged commit b3d73e6 into develop Apr 18, 2023
@fabiencastan fabiencastan deleted the dev/viewer2DFilePathPatterns branch April 18, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants