Add a template for the HDR fusion#2032
Merged
Merged
Conversation
fabiencastan
previously requested changes
Jun 3, 2023
a962820 to
aa05868
Compare
Before this commit, the `Publish` node could only copy files to an output directory. It can now copy a complete directory to an output directory. This is useful for cases where the names or number of the files to publish are unknown prior to the computation of the node to publish.
Being able to connect the output folder instead of only the output SfMData file might be useful for the `LdrToHdrMerge` node since it produces more than a single SfMData file as outputs.
aa05868 to
377db68
Compare
mugulmd
approved these changes
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new template to perform a stand-alone HDR fusion, which used to be only available in the HDR panorama templates.
As the
LdrToHdrMergenode's only output was an SfMData file, its output folder is now exposed so that results of the fusion are available.The
Publishnode's support for inputs has also been extended to folders: if a folder is provided in the list of inputs, its content will be recursively published to the output folder.Features list
Publishnode;LdrToHdrMergenode;