KeyframeSelection: Add new parameter value to disable the export of keyframes#2036
Merged
Conversation
…frames The `outputExtension` parameter now supports a new value, `none`, that disables the export of the keyframes, and becomes the new default value. The `renameKeyframes` parameter, which changes the way keyframes are named when they are written, is automatically disabled when `outputExtension` is set to `none`.
2 tasks
mugulmd
approved these changes
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related AliceVision pull request: alicevision/AliceVision#1454
This PR adds the support of the
nonevalue for theoutputExtensionparameter in theKeyframeSelectionnode, and sets it as the default value. SettingoutputExtensiontononedisables the export of the selected keyframes, meaning that only the SfMData files will be written on disk as outputs of theKeyframeSelectionnode.The description of the parameter is updated accordingly and mentions that it should not be used with video inputs, as this would lead to no output at all.