tolerant bracket size selection#2113
Merged
Merged
Conversation
3f7cf68 to
6a0583d
Compare
In addition to comparing the exposure levels of the sorted input images to determine whether a new exposure group must be created, this commit adds a detection based on the path of the image: if the directory containing the current image is not the same as the one of the previous image, then we assume the dataset is different, and there is no point in comparing the current image's exposure level with the previous one's. Instead, we directly create a new exposure group. In cases where images from different datasets have very similar exposure levels, this prevents having outliers identified as being part of the current exposure group.
cbentejac
approved these changes
Jul 17, 2023
cbentejac
left a comment
Contributor
There was a problem hiding this comment.
I added a detection for new exposure groups based on the path of the images to correctly handle cases where the outlier(s) might have an exposure level that would be coherent with the current exposure group, thus causing an erroneous bracket detection.
For example, if an outlier's exposure level is (22.0, 10.6, 200) and it gets sorted before a dataset whose first image has an exposure level of (22.0, 10.2, 200), both images would be put into the same exposure group unless we use the path information that's available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bracket size selection is now tolerant to at most two spurious image in the images list.
rule : (Bracket size * countGroupsWithThisSize) >= totalImages - 2