[core] Add new type of ChoiceParam that changes dynamically#2350
Merged
Conversation
153e970 to
b42e647
Compare
… to other values Add new type of ChoiceParam that changes dynamically according to other values. When value of an attribute is changed onAttributeChanged is called, allowing to have unique reaction within node files. Also add of callDesc function to be able to have other functions such as onNodeCreated at creation of node.
b42e647 to
498fd6c
Compare
Update of values from tuple to list for ChoiceParam to be consistent everywhere. Before it was not a problem but because of dynamic choices we expect it to be editable list.
… list Check of value type of ChoiceParam according to first value in list. We want to support something else than string.
Renaming and documentation added to onAttributeChanged and optionalCallOnDescriptor.
fabiencastan
reviewed
Apr 3, 2024
fabiencastan
reviewed
Apr 3, 2024
fabiencastan
approved these changes
Apr 3, 2024
fabiencastan
left a comment
Member
There was a problem hiding this comment.
Looks good to me, just one minor thing to fix.
dc166c3 to
eda3203
Compare
cbentejac
approved these changes
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new type of ChoiceParam that changes dynamically according to other values.
When value of an attribute is changed onAttributeChanged is called, allowing to have unique reaction within node files.
Also add of callDesc function to be able to have other functions such as onNodeCreated at creation of node.