New MultiView Photometric Stereo pipeline and new sfmFilter node#2582
Merged
Conversation
e7738b0 to
41c5b3e
Compare
Select views using regex
Pose transfert in SfMTransfert
The template has been renamed to fit the automatic name parsing of template files, it has been effectively converted to an actual template and all the nodes have been aligned coherently.
f94278c to
92a4db4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2582 +/- ##
===========================================
+ Coverage 69.85% 69.89% +0.03%
===========================================
Files 120 121 +1
Lines 7067 7076 +9
===========================================
+ Hits 4937 4946 +9
Misses 2130 2130 ☔ View full report in Codecov by Sentry. |
fabiencastan
approved these changes
Dec 13, 2024
fabiencastan
left a comment
Member
There was a problem hiding this comment.
Validating for now, but the SfMTransfer needs to be updated to propagate the landmarks with viewId associations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New pipeline for MV-PS.
New sfmFilter node: split sfm based on filenames regex
PR associated with alicevision/AliceVision#1769