[ui] Graph: In minimal refresh, do not poll files for chunks run locally#2672
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #2672 +/- ##
========================================
Coverage 72.67% 72.67%
========================================
Files 128 128
Lines 7692 7692
========================================
Hits 5590 5590
Misses 2102 2102 ☔ View full report in Codecov by Sentry. |
yann-lty
reviewed
Feb 16, 2025
When the minimal refresh mode is on, only chunks that are running, submitted or in error while their execution mode is external should be polled. Chunks that have the same status but with a local execution mode will be correctly updated as their status changes will be notified. The behaviour for the automatic refresh mode remains the same: all the chunks are polled, independently from their status and their execution mode.
e4f34b6 to
bae85d6
Compare
yann-lty
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the minimal refresh mode is on, only chunks that are running, submitted or in error while their execution mode is external should be polled.
Chunks that have the same status but with a local execution mode will be correctly updated as their status changes will be notified.
The behaviour for the automatic refresh mode remains the same: all the chunks are polled, independently from their status and their execution mode.