[GraphEditor] Only display "Pipelines" menu when templates are available#2678
Merged
Conversation
In the node menu (displayed when pressing "Tab" or right-clicking in the Graph Editor), the "Pipelines" menu entry used to be displayed even if there was no available template (the entry would open to display an empty list). This commit adds a check to ensure that the "Pipelines" menu is only added to the node menu if there is at least one template that is available. Otherwise, it is not displayed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #2678 +/- ##
========================================
Coverage 72.79% 72.79%
========================================
Files 129 129
Lines 7753 7753
========================================
Hits 5644 5644
Misses 2109 2109 ☔ View full report in Codecov by Sentry. |
yann-lty
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adjusts the display of the "Pipelines" entry in the node menu depending on the number of available templates. If no template is available, the entry simply is not added to the node menu; if there is at least one template, then it is added to the node menu.
Before this change, in the node menu (displayed when pressing "Tab" or right-clicking in the Graph Editor), the "Pipelines" menu entry used to be displayed even if there was no available template (the entry would open to display an empty list).
If no template is available at the beginning of the session but the user saves one in one of the folders that are expected to contain templates, the entry will be added to the menu without restarting the session.