[ui] Application: fix save-as dialog not working properly (Qt6.7+)#2683
Merged
Conversation
Since Qt 6.7, type annotations are enforced at runtime. Typing the `sourceSaveDialog` as Dialog (or Platform.FileDialog) breaks the value received by the function and its behavior.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #2683 +/- ##
========================================
Coverage 72.79% 72.79%
========================================
Files 129 129
Lines 7753 7753
========================================
Hits 5644 5644
Misses 2109 2109 ☔ View full report in Codecov by Sentry. |
cbentejac
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since Qt 6.7, JS type annotations are enforced at runtime (see https://doc.qt.io/qt-6/qtqml-javascript-hostenvironment.html#type-annotations-and-assertions).
This PR removes a problematic annotation typing that is breaking the SaveAs file dialog.
Features list
Implementation remarks
Typing the
sourceSaveDialoginvalidateFilepathForSaveas Dialog (or Platform.FileDialog) breaks the value received by the function and its behavior.