[build] Fixes for the generation of Meshroom's executable#2770
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2770 +/- ##
===========================================
- Coverage 77.77% 77.67% -0.10%
===========================================
Files 48 48
Lines 6681 6689 +8
===========================================
Hits 5196 5196
- Misses 1485 1493 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3e039ff to
eca592f
Compare
818f8fe to
cdfec75
Compare
Otherwise, when started with cxFreeze, an `AttributeError` is thrown as `os.__file__` does not seem to exist in this context.
Otherwise, some dynamic links cannot be resolved for `libqtquickscene3d.so`, which prevents the "Application" part from being displayed (with a "Component not ready" error).
4978023 to
cd4dbd3
Compare
fabiencastan
reviewed
Aug 3, 2025
fabiencastan
reviewed
Aug 3, 2025
fabiencastan
reviewed
Aug 3, 2025
fabiencastan
approved these changes
Aug 3, 2025
`libQt63DQuickScene3D.so` is missing from the default PySide6 install despite being present in the Qt 6.8.3 install. If it is missing, the "Application" part of Meshroom cannot be displayed as a "Component not ready" error is thrown. The missing library is thus copied from the Qt install folder, and its own dependencies are copied with it to prevent issues when looking for them.
Instead of calling the Python script, we call the executable that has been generated with the bundle when we detect that we are in release mode.
cd4dbd3 to
40b9dcb
Compare
fabiencastan
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces several updates focusing on improving Docker image builds, plugin support, and platform-specific compatibility. Key changes include enhancements to Dockerfiles for better dependency management, updates to enable plugin discovery and integration, and platform-specific adjustments for Windows and Linux environments.
Dockerfile Enhancements:
docker/Dockerfile_rocky,docker/Dockerfile_ubuntu). [1] [2]docker/Dockerfile_rocky,docker/Dockerfile_ubuntu). [1] [2]docker/Dockerfile_rocky_depsanddocker/Dockerfile_ubuntu_depsby addinglibglvnd-opengland updating Qt installation commands. [1] [2]Plugin Support:
pluginsdirectory inmeshroom/__init__.py. This includes updating environment variables to support plugins and AliceVision nodes/templates. [1] [2]pluginsfolder in the expected directory structure.Platform-Specific Adjustments:
setupInitScriptWindows.py) and updatedsetupInitScriptUnix.pyfor Linux to handle platform-specific paths and dependencies. [1] [2]setup.pyto include additional Python modules required for freezing the application and added platform-specific initialization scripts. [1] [2]meshroom_computein release package mode inmeshroom/core/desc/node.py. [1] [2]Miscellaneous:
docker/build-rocky.shto reflect the latest official release location.