Skip to content

[core] plugins: Downgrade the log level when loading the config file#2798

Merged
cbentejac merged 1 commit into
developfrom
fix/warningLoadConfig
Aug 11, 2025
Merged

[core] plugins: Downgrade the log level when loading the config file#2798
cbentejac merged 1 commit into
developfrom
fix/warningLoadConfig

Conversation

@cbentejac

Copy link
Copy Markdown
Contributor

Description

This pull request makes a minor adjustment to the logging behavior in the loadConfig method of meshroom/core/plugins.py. The change lowers the logging level from warning to debug for messages about missing resolved paths, reducing noise in the logs for non-critical issues.

@cbentejac cbentejac added this to the Meshroom 2025.1.0 milestone Aug 11, 2025
@cbentejac cbentejac requested review from Copilot and demoulinv August 11, 2025 12:54
@cbentejac cbentejac self-assigned this Aug 11, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reduces logging noise by downgrading a warning message to debug level when configuration file paths cannot be resolved. The change addresses non-critical missing path scenarios that were previously logged as warnings but are more appropriately handled as debug information.

  • Downgrades logging level from warning to debug for missing resolved paths in config loading

@codecov

codecov Bot commented Aug 11, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.46%. Comparing base (5a36cc5) to head (ee52562).
⚠️ Report is 2 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/plugins.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2798   +/-   ##
========================================
  Coverage    77.46%   77.46%           
========================================
  Files           48       48           
  Lines         6735     6735           
========================================
  Hits          5217     5217           
  Misses        1518     1518           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbentejac cbentejac merged commit 0362aab into develop Aug 11, 2025
4 of 5 checks passed
@cbentejac cbentejac deleted the fix/warningLoadConfig branch August 11, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants