Skip to content

MSVC build fix #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simogasp merged 2 commits into from
Jul 16, 2021
Merged

MSVC build fix #166

simogasp merged 2 commits into from
Jul 16, 2021

Conversation

@fabiencastan
Copy link
Member

@fabiencastan fabiencastan commented Jul 15, 2021 •
edited
Loading

To avoid this error:

Bresenham.obj : error LNK2019: unresolved external symbol "int __cdecl boost::math::sign<int>(int const &)" (??$sign@H@math@boost@@YAHAEBH@Z) referenced in function "class cctag::EdgePoint * __cdecl cctag::gradientDirectionDescent(class
 cctag::EdgePointCollection const &,class cctag::EdgePoint const &,int,unsigned __int64,class cv::Mat const &,class cv::Mat const &,int)" (?gradientDirectionDescent@cctag@@YAPEAVEdgePoint@1@AEBVEdgePointCollection@1@AEBV21@H_KAEBVMat@cv
@@3H@Z) [D:\release\CCTag\build-bundle\src\CCTag.vcxproj]
Bresenham.obj : error LNK2019: unresolved external symbol "int __cdecl boost::math::sign<float>(float const &)" (??$sign@M@math@boost@@YAHAEBM@Z) referenced in function "class cctag::EdgePoint * __cdecl cctag::gradientDirectionDescent(c
lass cctag::EdgePointCollection const &,class cctag::EdgePoint const &,int,unsigned __int64,class cv::Mat const &,class cv::Mat const &,int)" (?gradientDirectionDescent@cctag@@YAPEAVEdgePoint@1@AEBVEdgePointCollection@1@AEBV21@H_KAEBVMa
t@cv@@3H@Z) [D:\release\CCTag\build-bundle\src\CCTag.vcxproj]
D:\release\CCTag\build-bundle\Windows-AMD64\Release\CCTag.dll : fatal error LNK1120: 2 unresolved externals [D:\release\CCTag\build-bundle\src\CCTag.vcxproj]
P

@fabiencastan
[cctag] fix MSVC build
cabccd4 
Avoid build error with missing function boost::math::sign
@fabiencastan
minor update to gitignore
17a3e9c
@simogasp
Copy link
Member

simogasp commented Jul 15, 2021 •
edited
Loading

Can you also post the compilation error message, just for reference?
And which version of boost? Cause on vcpkg they use 1.76 and everything was ok

@simogasp simogasp added the build:windows anything related to the windows build label Jul 15, 2021
@simogasp simogasp added this to the v1.1.0 milestone Jul 15, 2021
@fabiencastan
Copy link
Member Author

fabiencastan commented Jul 15, 2021

I was using latest version of vcpkg with boost-1.76 and VS 2019.
I don't have the log anymore.

@fabiencastan
Copy link
Member Author

fabiencastan commented Jul 15, 2021

Log of the error added to the description.

simogasp
simogasp approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@simogasp simogasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simogasp simogasp merged commit c3dd85b into develop Jul 16, 2021
@simogasp simogasp deleted the fix/windows-build-math-sign branch July 16, 2021 08:54
@Blup1980 Blup1980 mentioned this pull request Aug 13, 2021
Closed
@simogasp simogasp modified the milestones: v1.1.0, v1.0.1 Aug 13, 2021
This was referenced Aug 13, 2021
Merged
Closed
@simogasp simogasp mentioned this pull request Sep 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simogasp simogasp simogasp approved these changes

Assignees

@simogasp simogasp

Labels

build:windows anything related to the windows build

Projects

None yet

Milestone

v1.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@fabiencastan @simogasp