Fix: Pass helm-org-rifle-after-init-hook as reference#77
Merged
Conversation
Owner
|
Thanks. When I have time, I'll make a new stable release with this fix. |
Closed
1 task
|
Thanks a lot @Thaodan ! |
|
Thank you for contributing this! This seems to fix the issue on my machine. Is there anything blocking this being merged? |
Contributor
Author
|
Lisp student ***@***.***> writes:
Is there a way to disable this, or it is indispensable for helm-rifle to work?
You should open a separate issue about this.
Don't hijack this PR.
|
Contributor
Author
|
I might be related but it's a different, create a new issue please.
|
bvraghav
added a commit
to bvraghav/dotemacs
that referenced
this pull request
Mar 18, 2023
helm-org-rifle-after-init-hook was passed as string. Helm sends a warning when ~after-init-hook~ is not a symbol during functions such as ~helm-org-rifle~: Warning (emacs): Helm source ‘file.org’: after-init-hook Should be defined as a symbol Signed-off-by: Björn Bidar <bjorn.bidar@thaodan.de>
5f480ae to
0e97d47
Compare
Owner
|
@Thaodan Thanks for the fix, and to you and @thierryvolpiatto for your patience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
helm-org-rifle-after-init-hook was passed as string. Helm sends a
warning when
after-init-hookis not a symbol during functions such ashelm-org-rifle:Warning (emacs): Helm source ‘file.org’: after-init-hook Should be defined as a symbol