Punctuation commands fix (Issue #111)#116
Merged
Merged
Conversation
1 similar comment
ivanistheone
commented
Oct 18, 2020
| for point in PUNCTUATION_COMMANDS: | ||
| if text.peek((0, len(point))) == point: | ||
| result = text.forward(len(point) + 1) | ||
| result = text.forward(len(point)) |
Owner
|
Many thanks for the PR @ivanistheone! Haha now I'm wondering why I ever added that +1. Accepting and merging. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes indeed. After this change
PunctuationCommandNames no longer "gobble" the following charaacter and seem to behave as expected.I've added some tests (if tokens serialize back to string correctly, then they must have been tokenized together as a unit). By coincidence I happened to choose a delimiter
\rfloorand test was failing... so we ended up with a bonus typo fix.Last but not least I added three more verbatim-type environments (users can manually add those to
skip_envsif needed, but seems like a good idea to have them "baked in").