fix: remove !important from workspace session tab custom background to allow color overrides#11
Merged
Conversation
… custom color overrides from the custom color picker
amirlehmam
added a commit
that referenced
this pull request
May 11, 2026
- Fix #12: workspacePrefs (defaultShell, placement, auto-reorder) had no persistence layer, so any value the user picked in Settings was lost on the next launch — the "Default shell" toggle felt broken even when it saved into state during the session. Adds a scoped localStorage layer for just this slice (key: wmux-workspace-prefs); failures are swallowed so sandboxed/locked storage can't break the renderer boot. - Annotates the .workspace-row--active rule (fix for #10 landed via #11) so the next person doesn't reintroduce !important and break custom workspace colors again. Bumps version to 0.7.18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: workspace session tab background now updates correctly when selecting a color
This fixes an issue where the workspace did not update its background color when using the custom color choosers.
Root Cause
The CSS rule for the workspace used
!important, which prevented background styles (color picker) from having effect.Fix Applied
Removed
!importantso inline styles take precedence: