Add spell components to character info #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35
Adds scarab and prismatic taper counts to character info sent to treestats.
Research
Documentation for Decal libraries are hard to track down, so I looked for examples from other plugins instead. I found an example from
StatsDump(authored by Optim actually). I recommend this as a resource for other character information (such as location).https://github.com/OptimShi/StatsDump/blob/36ed8d8a6e7573285bcc84c20f2da74733528575/PluginCore.cs#L530-L577
https://github.com/OptimShi/StatsDump/blob/36ed8d8a6e7573285bcc84c20f2da74733528575/PluginCore.cs#L679-L725
Approach for Inventory item counts
GetItemInventoryCountmethod is mostly the same implementation as seen inStatsDump-- only difference is contextual things (like where to get theCoreManagerreference).There's knowledge in there that I can only make assumptions about: The two loops contributing to the final count is hinting at how main pack and additional packs are represented.
worldObject.Category == 512must be a pointer to additional packs which must be dug into separately (second loop) to complete the full count.Disclaimer
Unable to test fully due to lack of know how, testing framework, and working Windows machine. I could use some help there. At the very least, I hope this is a good starting point.