Make arctan2 work with Quantities #1179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that x and y use the same unit, which is otherwise ignored (it is divided out).
LourensVeen
previously approved these changes
Oct 1, 2025
Member
LourensVeen
left a comment
There was a problem hiding this comment.
Whoops! Yes, that seems like a good idea. Maybe add a regression test for it?
Member
Author
|
Added tests and fixed a regression :) |
rieder
commented
Oct 1, 2025
| arctan2 = lambda x, y: numpy.arctan2(x, y) | rad | ||
| arctan2 = lambda x, y: numpy.arctan2( | ||
| x.value_in(x.unit) if isinstance(x, quantities.Quantity) else x, | ||
| y.value_in(x.unit) if isinstance(x, quantities.Quantity) else y, |
Member
Author
There was a problem hiding this comment.
Note that this explicitly checks the unit of x in both cases, and also whether x is a Quantity. This is because x and y need to be treated in the same way, otherwise they might have different units.
LourensVeen
approved these changes
Oct 1, 2025
Member
LourensVeen
left a comment
There was a problem hiding this comment.
Ah, hadn't considered that. I should spend more time using AMUSE I guess 😄. Nice find though! Hurray for testing things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that x and y use the same unit, which is otherwise ignored (it is divided out).