fix: use location RealPath not String() for match sorting
#1950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1944. Using
String()works mostly for sorting, but I expectedString()to return a simple filepath, and instead it returns a funky string like:Location<id=72 RealPath="usr/lib/go/pkg/tool/linux_amd64/buildid">.This causes issues because the
id=<...>value will be sorted lexically, and more than that, it looks like for most paths in Syft, thisidvalue is controlled by an auto-incrementing global variable, so its value will vary quite widely across different execution contexts.(I'm not sure if anything is depending on this kind of
Location< .... >string value... If not, it could potentially be worth considering changingString()to return the RealPath or AccessPath to be friendlier to library consumers.)This PR updates the sorting logic to use the
RealPathfor now, which should be stable. Holler if this assumption is incorrect for any reason!