fix: unaffected package ignore rules #3066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <kzantow@gmail.com>
kzantow
commented
Nov 21, 2025
| } | ||
| } | ||
|
|
||
| func Test_indexFalsePositivesByLocation(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
This test was moved to the more appropriate APK matcher package, note the apk package import is no longer required.
kzantow
commented
Nov 21, 2025
| } | ||
| } | ||
|
|
||
| func Test_filterMatchesUsingDistroFalsePositives(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
This test was refactored with additional cases to match the current functionality of IgnoreFilters ☝️ it's probably a lot easier to read the test cases directly rather than looking at a diff 👇
wagoodman
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where unaffected records for vulnerabilities found for language matches did not apply to the same package when an identical CPE match was also found.
Fixes #3056