fix: make utp_types.h safer and compatible with cgo/Go builds#32
Merged
Conversation
Contributor
0rteip
commented
Nov 13, 2025
- include <stdint.h> and <stdbool.h> for consistent integer/boolean types
- avoid retypedefs when types already exist
- normalize macros and spacing
- keep original behavior on non-C99 platforms\n
…clude <stdint.h> and <stdbool.h> for consistent integer/boolean types\n- avoid retypedefs when types already exist\n- normalize macros and spacing\n- keep original behavior on non-C99 platforms\n
Owner
|
Note that we try to minimise the diff from upstream, although admittedly it has ossified, and clearly done this stuff poorly. |
Contributor
Author
|
Thanks for the clarification! This was actually my first time working with Go. The project I am working on wasn’t compiling on my side, so I tried a quick fix without noticing the upstream considerations. |
Owner
|
I fixed CI on master, will merge as soon as it passes. |
Owner
|
I tested it locally and had no issues. No reason to block. |
Contributor
Author
|
Great, thank you! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.