-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Lattice support for ad738x_fmc project on LFCPNX-EVN (lfcpnx) carrier board. #1766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ladace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, fix Iulia's change requests
|
RetriggerCI |
9033efe to
6f02fd8
Compare
|
f05ff12 to
d429ecc
Compare
|
Version 2 Added a fix for AXI STREAM input interface of the DMA. The wrapper generator generated TLAST=1 based on the Lattice AXI Stream interface definition for the AXI STREAM input of the DMA because we do not have that signal implemented on the SPI Engine Offload. This caused the DMA to stop the transaction after receiving the first offload data word. I forced the TLAST input of the DMA to 0 in block design to fix it. Updated the base design and the design to match with the ZedBoard version (160 MHz SPI Engine clock). Added full design simulation support. Extended the docs/projects/ad738x_fmc/index.rst. |
|
Version 3.
|
PopPaul2021
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I've built the design, and there are no major errors or critical warnings.
StancaPop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for the documentation related sections.
IuliaCMoldovan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved the doc changes
library/interfaces_ltt/interfaces_ltt.tcl: Updating SPI Master interface definition. CI related updates for build path and clean. Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
Adding parameter injection support for block design and top module: * projects/scripts/adi_project_lattice.tcl * projects/scripts/adi_project_lattice_pb.tcl Updates for sysid_gen_sys_init_file compatibility in: * projects/scripts/adi_project_lattice_pb.tcl * projects/scripts/project-lattice.mk Adding simulation project support. The '<carrier>/sim.tcl' (default) simulation project file is sourced (if exists) to create a simulation design in a similar way than the project block designs are created. It is possible to create and add simulation IPs and connect them to the block design wrapper module. projects/scripts/project-lattice.mk: Adding FORCE to lib deps build. Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
Adding sysid support. Adding external UART for interrupt compatibility. Updating IP versions. Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
…rrier support. Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
Adding default interface folder searching to Propel Builder project build. The default interface folder name to search in hdl/library is the 'interfaces_ltt'. Updating the default relative build path for Lattice interface build to 'ltt'. This is a CI related requirement. Signed-off-by: Villyam <Vilmoscsaba.Jozsa@analog.com>
c7aec8b to
b89a1cc
Compare
PR Description
spi_engine_interconnect_ctrlinterface tospi_engineIPs.projects/common/lfcpnx: Updating base design and IP versions.ad738x_fmc/lfcpnx:Adding suport for Lattice LFCPNX-EVN carrier.docs/user_guide/build_hdl.rst:Updates for first project.docs/projects/ad738x_fmc/index.rst:Updates for Lattice Lattice LFCPNX-EVN carrier support.PR Type
PR Checklist