iio: frequency: adf4030: Add 3v3 CMOS support #3062
+33
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support to enable the 3.3v logic levels based on device tree configuration through adi,cmos-3v3-enable. Register 0x5C which contains interrupt masks and CMOS_OV field was moved from the default register array to manually configured in adf4030_startup. Signed-off-by: Brent Kowal <brent.kowal@analog.com>
Adds the adi,cmos-3v3-enable property to the documentation. Signed-off-by: Brent Kowal <brent.kowal@analog.com>
nunojsa
reviewed
Dec 22, 2025
Collaborator
nunojsa
left a comment
There was a problem hiding this comment.
Just one minor comment. Also, as a kind of process comment, bindings patches should come first.
| description: | ||
| When set the CMOS output level is 3.3V. This applies to SPI | ||
| MUXOUT, and IRQB.(Default is 1.8V) | ||
| $ref: /schemas/types.yaml#/definitions/flag |
Collaborator
There was a problem hiding this comment.
type: boolean instead of the $ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds device tree parameter to enable the 3.3v logic levels for the ADF4030.
Register 0x5C (IRQ Masks and CMOS_OV) was part of the default register listing. This was moved to be manually configured in adf4030_startup to avoid having to configure CMOS_OV prior to testing the interface with the scratchpad then again after the default value was written.
PR Type
PR Checklist