Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

Make tests optional #1632

Open
uis246 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make tests optional #1632

uis246 wants to merge 1 commit into from

Conversation

@uis246
Copy link

@uis246 uis246 commented Oct 6, 2020

Second from #1628

@uis246
Copy link
Author

uis246 commented Oct 6, 2020

For testing enable "CMAKE_TESTING_ENABLED" flag

morphis
morphis suggested changes Oct 11, 2020
View reviewed changes
@necessarily-equal
Copy link
Contributor

necessarily-equal commented Oct 11, 2020

Note that we do have BUILD_TESTING because cpu_features define it. Maybe we should reuse the name?

@uis246
Copy link
Author

uis246 commented Oct 11, 2020 •
edited
Loading

Note that we do have BUILD_TESTING because cpu_features define it.

Thanks

@uis246 uis246 force-pushed the master branch 7 times, most recently from d3dd409 to c5fe8c5 Compare October 19, 2020 06:55
@uis246
Copy link
Author

uis246 commented Oct 19, 2020

Done

@jnnks jnnks mentioned this pull request Nov 3, 2020
Closed
@stale
Copy link

stale bot commented Jun 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the decaying label Jun 18, 2021
@necessarily-equal
Copy link
Contributor

necessarily-equal commented Jun 22, 2021

still useful

@stale stale bot removed the decaying label Jun 22, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the decaying label Apr 16, 2022
@uis246
Copy link
Author

uis246 commented Apr 17, 2022

!

@stale stale bot removed the decaying label Apr 17, 2022
@uis246 uis246 requested a review from morphis April 17, 2022 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@morphis morphis Awaiting requested review from morphis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@uis246 @necessarily-equal @morphis