Skip to content

tests: save plack logs to a file.#520

Merged
rspier merged 1 commit into
andk:masterfrom
rspier:shh2
May 18, 2024
Merged

tests: save plack logs to a file.#520
rspier merged 1 commit into
andk:masterfrom
rspier:shh2

Conversation

@rspier

@rspier rspier commented May 16, 2024

Copy link
Copy Markdown
Collaborator

Save the plack logs from tests to a file, and then upload that file as an artifact. This significantly quiets/shortens the output from the tests.

Implement by creating a new plack log environment config ghaction.

Save the plack logs from tests to a file, and then upload that file as an
artifact. This significantly quiets/shortens the output from the tests.

Implement by creating a new plack log environment config `ghaction`.
@rspier rspier requested review from charsbar and rjbs May 16, 2024 03:33
@rspier

rspier commented May 16, 2024

Copy link
Copy Markdown
Collaborator Author

@charsbar WrapAction.pm line 28 is one of the remaining sources of logs during the tests. I played with changing it, but only ended up breaking other tests. (Weird that changing something written to STDERR could break tests....) Any thoughts on the best way to send those errors through the logging framework?

I know @rjbs is thinking about long-term logging stuff, but in the short- term I'm just trying to improve developer experiences.

@rjbs rjbs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a GH expert or a Mojo expert, but I this seems sensible from what I understand.

@rspier rspier merged commit d7f0be5 into andk:master May 18, 2024
@rspier rspier deleted the shh2 branch May 18, 2024 06:30
@rspier

rspier commented May 18, 2024

Copy link
Copy Markdown
Collaborator Author

@charsbar I've merged this because it's definitely a dev usability improvement. I'm still interested in improving WrapAction's output, and to know if this was the best way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants