Minor parser improvements #139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks, these look like great improvements! I prefer keeping it explicit that arguments are optional (eace7b1) though, even if it's not as terse. I'll cherry-pick and merge once v0.9.0 is out. Don't mind the CI failure: I haven't found a good way to bump version constraints prior to getting the new package released on OPAM. If you have any further interest in contributing to |
Owner
|
Cherry-picked and pushed to master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really cool to see the parser switch to Menhir. I thought I might chip in with a few minor parser improvements. Cherry-pick the ones you find useful.