Skip to content

Only apply top border radii on first table header row #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristopherBilg merged 1 commit into from
Jan 17, 2024
Merged

Only apply top border radii on first table header row #111

ChristopherBilg merged 1 commit into from
Jan 17, 2024

Conversation

@harrymander
Copy link
Contributor

@harrymander harrymander commented Jan 17, 2024 •
edited
Loading

Makes tables that have multiple tr elements inside thead look nicer.

E.g. based on index.html, before:

Screenshot from 2024-01-17 16-39-38

After:

Screenshot from 2024-01-17 16-39-54

HTML:

<table>
  <thead>
      <tr>
          <th rowspan="2">Feature</th>
          <th colspan="3">CSS framework</th>
      </tr>
      <tr>
          <th>MVP.css</th>
          <th>No CSS</th>
          <th>Custom CSS</th>
      </tr>
  </thead>
 <!-- ... -->
</table>

ChristopherBilg
ChristopherBilg approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@ChristopherBilg ChristopherBilg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Good find and thanks for the PR

@ChristopherBilg ChristopherBilg merged commit 5879799 into andybrewer:master Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristopherBilg ChristopherBilg ChristopherBilg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harrymander @ChristopherBilg