Implemented Todo (RGB image conversion) #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
When I tried out the image segmentation pipeline, I got an error message saying that some method in RawImage wasn't implemented yet and is in todo. https://github.com/ankane/informers/blob/master/lib/informers/utils/image.rb#L74-L80
I made an attempt at implementing it and getting it to work.
I also tried to find a similar image as the test case
def test_image_segmentationto make sure that the implementation actually segments properly. When comparing the results to the test case:It gives almost identical numbers, I'd call it a success.
I also refactored the previous initial check in the method because it only verified if
@channels == 3. So other cases were 3 channel but not sRGB (like LAB) could lead to prematurely returning images.The changes do the following: