Arm64 #1495
Merged
Arm64 #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently they've simplified the url for zabbix 7.2, which is a welcome change.
Simplifies the playbook, and shows variables available for overrides by users more clearly.
Whenever we prefix a variable with _, we're essentially saying it's an internal variable not meant to be overridden by users, so it's cleaner if they're not presented in defaults.
pyrodie18
requested changes
Apr 1, 2025
Collaborator
pyrodie18
left a comment
There was a problem hiding this comment.
Toss the change fragment in but looks good
Zabbix provides packages for many archtectures on debian; i386, amd64, armhf, and arm64. So we need a lookup/map for these. I'm switching the check from machine to architecture in ansible_facts, because architecture is a closer match to whatever the operatingsystem compiled for, rather than the machine type it's running on. (machine can report i686, while the architecture reports i386.) This is not foolproof however as you can run an armhf based os on a 64-bit arm board, and ansible will report the architecture as aarch64. (quite possibly an ansible bug) So we put the zabbix_repo_deb_arch to defaults, so it can be overridden by the user in such cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Zabbix 7.2 put arm64 packages in the main repo for debian and ubuntu, so no need to postfix with -arm64 anymore.
This fixes #1491
ISSUE TYPE
COMPONENT NAME
roles/zabbix_repo
ADDITIONAL INFORMATION
Tested and confirmed working for debian bookworm on aarch64