Remove Support for Zabbix 6.4 #1548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1548 +/- ##
==========================================
+ Coverage 78.74% 78.77% +0.02%
==========================================
Files 48 48
Lines 6145 6144 -1
Branches 1600 1599 -1
==========================================
+ Hits 4839 4840 +1
+ Misses 796 795 -1
+ Partials 510 509 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eb4x
approved these changes
Jun 10, 2025
Collaborator
eb4x
left a comment
There was a problem hiding this comment.
Small nits, but looks good either way 👍
| ansible.builtin.assert: | ||
| that: | ||
| - zbx_settings_failed is failed | ||
| when: zabbix_version is version('6.0', '==') |
Collaborator
There was a problem hiding this comment.
could you move this condition to above the block? (https://ansible.readthedocs.io/projects/lint/rules/key-order/)
| timeout_script: 3s | ||
| timeout_browser: 60s | ||
| register: zbx_settings | ||
| when: zabbix_version is version('7.0', '>=') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Closes #1534